Disable the field alignment lint check#4560
Merged
andrewsykim merged 5 commits intoray-project:masterfrom Mar 11, 2026
Merged
Conversation
jinbum-kim
requested review from
MortalHappiness,
andrewsykim,
kevin85421 and
rueian
as code owners
andrewsykim
requested changes
Mar 4, 2026
| // +kubebuilder:resource:categories=all | ||
| // +kubebuilder:storageversion | ||
| // | ||
| //nolint:govet // RayCronJob is the Schema for the raycronjobs API |
Member
There was a problem hiding this comment.
Keep the original comment // RayCronJob is the Schema for the raycronjobs API
| // EDIT THIS FILE! THIS IS SCAFFOLDING FOR YOU TO OWN! | ||
| // NOTE: json tags are required. Any new fields you add must have json tags for the fields to be serialized. | ||
|
|
||
| //nolint:govet // RayCronJobSpec defines the desired state of RayCronJob |
Member
There was a problem hiding this comment.
Keep original comment // RayCronJobSpec defines the desired state of RayCronJob
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
jinbum-kim
force-pushed
the
chore/disable-fieldalignment-lint
branch
from
addf402 to
a927077
Compare
Contributor
Author
|
Hi @andrewsykim, I reproduced this locally and confirmed that running Would it be okay if I add a follow-up commit with those regenerated files? |
Member
|
Yes I think it's fine to leave the |
Contributor
Author
|
Regarding the Please let me know how you'd like to proceed, and I'll update accordingly! (regenerated files in this or other issue, etc.) |
Member
|
Please remove |
Signed-off-by: jinbum9958 <jinbum9958@gmail.com>
Signed-off-by: jinbum9958 <jinbum9958@gmail.com>
Signed-off-by: jinbum9958 <jinbum9958@gmail.com>
Signed-off-by: jinbum9958 <jinbum9958@gmail.com>
jinbum-kim
force-pushed
the
chore/disable-fieldalignment-lint
branch
from
a927077 to
0163020
Compare
Contributor
Author
|
Could someone please trigger the git actions test? thanks! |
Member
|
triggered |
Signed-off-by: jinbum9958 <jinbum9958@gmail.com>
Contributor
Author
|
I'm sorry but I missed the previous comment about regenerating everything, so I initially pushed a commit with only the source changes. I’ve now added a follow-up commit with the regenerated artifacts. Could you please re-run the git actions checks? |
andrewsykim
approved these changes
Mar 11, 2026
hango880623
pushed a commit
to hango880623/kuberay
that referenced
this pull request
Mar 13, 2026
* chore: disable govet fieldalignment lint Signed-off-by: jinbum9958 <jinbum9958@gmail.com> * chore: remove redundant //nolint:govet comments Signed-off-by: jinbum9958 <jinbum9958@gmail.com> * chore: restore RayCronJobSpec/RayCronJob comments Signed-off-by: jinbum9958 <jinbum9958@gmail.com> * chore: restore RayCronJob comment Signed-off-by: jinbum9958 <jinbum9958@gmail.com> * chore: regenerate artifacts for RayCronJob comment changes Signed-off-by: jinbum9958 <jinbum9958@gmail.com> --------- Signed-off-by: jinbum9958 <jinbum9958@gmail.com>
rueian
added a commit
that referenced
this pull request
Mar 19, 2026
* Disable RayMultiHostIndexing feature for TestReconcile_Multihost_Replicas (#4583) Signed-off-by: Future-Outlier <eric901201@gmail.com> * Disable the field alignment lint check (#4560) * chore: disable govet fieldalignment lint Signed-off-by: jinbum9958 <jinbum9958@gmail.com> * chore: remove redundant //nolint:govet comments Signed-off-by: jinbum9958 <jinbum9958@gmail.com> * chore: restore RayCronJobSpec/RayCronJob comments Signed-off-by: jinbum9958 <jinbum9958@gmail.com> * chore: restore RayCronJob comment Signed-off-by: jinbum9958 <jinbum9958@gmail.com> * chore: regenerate artifacts for RayCronJob comment changes Signed-off-by: jinbum9958 <jinbum9958@gmail.com> --------- Signed-off-by: jinbum9958 <jinbum9958@gmail.com> * Mark RC releases as pre-release in GoReleaser (#4590) Signed-off-by: Future-Outlier <eric901201@gmail.com> * Add example YAML for manually enabling Ray k8s auth (#4582) Signed-off-by: Andrew Sy Kim <andrewsy@google.com> * [RayService] Rollback Support for Incremental Upgrades (#4109) * Implement rollback support Signed-off-by: Ryan O'Leary <ryanaoleary@google.com> * Fix unit test file Signed-off-by: Ryan O'Leary <ryanaoleary@google.com> * Ensure upgrade in progress status is cleared Signed-off-by: Ryan O'Leary <ryanaoleary@google.com> * Clarify rollback scenarios and clear pending apps during rollback Signed-off-by: Ryan O'Leary <ryanaoleary@google.com> * Fix typo Signed-off-by: Ryan O'Leary <ryanaoleary@google.com> * Add guard for rollback to prepare new cluster Signed-off-by: Ryan O'Leary <ryanaoleary@google.com> * fix e2e test checking pending cluster name Signed-off-by: Ryan O'Leary <ryanaoleary@google.com> * Fix rollback calculation Signed-off-by: Ryan O'Leary <ryanaoleary@google.com> * Fix httproute name in test Signed-off-by: Ryan O'Leary <ryanaoleary@google.com> * Increase timeout for checking RayCluster deletion Signed-off-by: Ryan O'Leary <ryanaoleary@google.com> * Fix rollback check and change httproute equal check so it doesn't always evaluate false Signed-off-by: Ryan O'Leary <ryanaoleary@google.com> * Adjust logic to use timestamp of growing cluster Signed-off-by: Ryan O'Leary <ryanaoleary@google.com> * Fix naming of vars Signed-off-by: Ryan O'Leary <ryanaoleary@google.com> --------- Signed-off-by: Ryan O'Leary <ryanaoleary@google.com> Signed-off-by: Ryan O'Leary <113500783+ryanaoleary@users.noreply.github.com> * [RayService] Promote Incremental Upgrade Feature to Beta (#4599) Signed-off-by: Ryan O'Leary <ryanaoleary@google.com> * Revert "[RayService] Promote Incremental Upgrade Feature to Beta (#4599)" (#4602) This reverts commit 0c8aab9. * [Github Action] Skip krew-index update for pre-release tags (#4587) * [CI] Skip krew-index update for pre-release tags Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Future-Outlier <eric901201@gmail.com> * update Signed-off-by: Future-Outlier <eric901201@gmail.com> --------- Signed-off-by: Future-Outlier <eric901201@gmail.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> * [Helm] update ray-cluster chart to apiVersion: v2 (#4593) * Update kind configs and docs to v1.29.0 (#4595) * Remove ingress template support for k8s < 1.19 (#4591) * [Helm] Update ray-cluster default resource values (#4588) * update kuberay 1.6.0 helm chart and readme Signed-off-by: Future-Outlier <eric901201@gmail.com> * [Helm] Fix apiserver README chart version and align ray-cluster resource defaults Signed-off-by: Future-Outlier <eric901201@gmail.com> * update Signed-off-by: Future-Outlier <eric901201@gmail.com> * update Signed-off-by: Future-Outlier <eric901201@gmail.com> * update Signed-off-by: Future-Outlier <eric901201@gmail.com> * update Signed-off-by: Future-Outlier <eric901201@gmail.com> * update Signed-off-by: Future-Outlier <eric901201@gmail.com> * update Signed-off-by: Future-Outlier <eric901201@gmail.com> * update Signed-off-by: Future-Outlier <eric901201@gmail.com> * fix ctl test Signed-off-by: Future-Outlier <eric901201@gmail.com> * update Signed-off-by: Future-Outlier <eric901201@gmail.com> * update Signed-off-by: Future-Outlier <eric901201@gmail.com> --------- Signed-off-by: Future-Outlier <eric901201@gmail.com> * fix lint Signed-off-by: Future-Outlier <eric901201@gmail.com> * chore: Use RayCluster name as SA name for RBAC auth (#4611) Signed-off-by: JiangJiaWei1103 <waynechuang97@gmail.com> * Add Google Artifact Registry image build/push guide (#4618) * [History Server] Fix API response format to match Ray Dashboard frontend schema (#4615) * [History Server] Fix API response format to match Ray Dashboard frontend schema Signed-off-by: Future-Outlier <eric901201@gmail.com> * update Signed-off-by: Future-Outlier <eric901201@gmail.com> * update Signed-off-by: Future-Outlier <eric901201@gmail.com> * fix bug 1 Signed-off-by: Future-Outlier <eric901201@gmail.com> * update Signed-off-by: Future-Outlier <eric901201@gmail.com> * add comments to explain frontend fields naming issue Signed-off-by: Future-Outlier <eric901201@gmail.com> * fix tests Signed-off-by: Future-Outlier <eric901201@gmail.com> * Add comments Signed-off-by: Future-Outlier <eric901201@gmail.com> * update Signed-off-by: Future-Outlier <eric901201@gmail.com> * Add frontend reference for this PR Signed-off-by: Future-Outlier <eric901201@gmail.com> * fix codex and cursor bug Signed-off-by: Future-Outlier <eric901201@gmail.com> * upadte Signed-off-by: Future-Outlier <eric901201@gmail.com> * add actor.LabelSelector Signed-off-by: Future-Outlier <eric901201@gmail.com> * better query for additional endpoints, request URI (path + query) Signed-off-by: Future-Outlier <eric901201@gmail.com> * Add comments Signed-off-by: Future-Outlier <eric901201@gmail.com> --------- Signed-off-by: Future-Outlier <eric901201@gmail.com> --------- Signed-off-by: Future-Outlier <eric901201@gmail.com> Signed-off-by: jinbum9958 <jinbum9958@gmail.com> Signed-off-by: Andrew Sy Kim <andrewsy@google.com> Signed-off-by: Ryan O'Leary <ryanaoleary@google.com> Signed-off-by: Ryan O'Leary <113500783+ryanaoleary@users.noreply.github.com> Signed-off-by: JiangJiaWei1103 <waynechuang97@gmail.com> Co-authored-by: Han-Ju Chen (Future-Outlier) <eric901201@gmail.com> Co-authored-by: Jinbum Kim <jinbum9958@gmail.com> Co-authored-by: Andrew Sy Kim <andrewsy@google.com> Co-authored-by: Ryan O'Leary <113500783+ryanaoleary@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Matt Boersma <Matt.Boersma@microsoft.com> Co-authored-by: Jia-Wei Jiang <36886416+JiangJiaWei1103@users.noreply.github.com> Co-authored-by: Chia-Yi Liang <aaronliang@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR is related to #4557.
This PR disables the
govetfieldalignmentanalyzer in golangci-lint configuration to reduce lint noise and avoid forcing struct field reordering for readability reasons.As a follow-up to disabling it, the
golangci-lintpre-commit hook updated a couple of files by removing now-unnecessary//nolint:govetannotations.Related issue number
closes #4557
Checks